Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2022-24686 Nomad go-getter Race Condition #12036

Closed
lgfa29 opened this issue Feb 9, 2022 · 1 comment
Closed

CVE-2022-24686 Nomad go-getter Race Condition #12036

lgfa29 opened this issue Feb 9, 2022 · 1 comment

Comments

@lgfa29
Copy link
Contributor

lgfa29 commented Feb 9, 2022

Summary

Nomad and Nomad Enterprise (“Nomad”) uses go-getter in an unsafe way, allowing a race condition such that the Nomad client agent could download the wrong artifact into the wrong destination. This vulnerability, CVE-2022-24686, was fixed in Nomad 1.0.17, 1.1.12, and 1.2.6..

Background

Nomad uses the go-getter library to download artifacts defined in job definitions. This library can be used in a way that is unsafe if shared between goroutines. Under the right conditions, this can allow an attacker with job submission capabilities to impact another allocation such that the client will place the wrong artifact into the wrong destination.

We expect this to be difficult or impossible to reliably exploit on a live cluster, as an attacker would need to get two artifact downloads to kick off at just the right time, outside of their own job submission.

Details

During internal testing, it was observed that Nomad’s go-getter client is used in an unsafe way using the builtin go test race detector. Nomad’s logic has been modified to no longer allow this attack.

Remediation

Customers should evaluate the risk associated with this issue and consider upgrading to Nomad or Nomad Enterprise 1.0.17, 1.1.12, and 1.2.6, or newer. Please refer to Upgrading Nomad for general guidance and version-specific upgrade notes.

@lgfa29 lgfa29 changed the title placeholder CVE-2022-24686 Nomad go-getter Race Condition Feb 10, 2022
@tgross tgross closed this as completed Feb 11, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants