client: expose network namespace CNI config as task env vars. #11810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iirc these represent the host assignments when running in |
|
|
jrasell
force-pushed
the
f-alloc-network-namespace-env-vars
branch
from
5830f28
to
0a89baa
Compare
|
I've just tested this in a CNI network using calico. It works great and saved a bunch of hassle modding container images to autodetect their IP. Thanks @jrasell. |
jrasell
force-pushed
the
f-alloc-network-namespace-env-vars
branch
from
f866228
to
7b9e54c
Compare
Ember Test Audit comparison
|
This change exposes CNI configuration details of a network namespace as environment variables. This allows a task to use these value to configure itself; a potential use case is to run a Raft application binding to IP and Port details configured using the bridge network mode.
jrasell
force-pushed
the
f-alloc-network-namespace-env-vars
branch
from
7b9e54c
to
1282575
Compare
jrasell
requested review from
shoenig and
angrycub
and removed request for
lgfa29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot I had this stashed locally. Raising it initially as a draft PR
to get early feedback and will modify and add docs etc at a later
date.
This change exposes CNI configuration details of a network
namespace as environment variables. This allows a task to use
these value to configure itself; a potential use case is to run
a Raft application binding to IP and Port details configured using
the bridge network mode.