Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workers should check eval token before submitting Ack/Nack #11727

Open
tgross opened this issue Dec 21, 2021 · 0 comments
Open

workers should check eval token before submitting Ack/Nack #11727

tgross opened this issue Dec 21, 2021 · 0 comments

Comments

@tgross
Copy link
Member

tgross commented Dec 21, 2021

If a leader election happens while a scheduler worker is processing an eval, when it tries to submit the plan to the new leader the leader will reject these with the error message "evaluation token does not match". Field experience has shown this error message is confusing. Workers should be able to verify that the token is valid before sending the ack/nack. This will reduce useless RPC traffic during the expensive leadership transition and more importantly reduce operator confusion.

cc @schmichael @davemay99 from our conversation around #11638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant