Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: support namespace wildcard in CSI volume list #11724

Merged
merged 2 commits into from
Dec 21, 2021
Merged

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Dec 21, 2021

The lack of wildcard listing impacted the UI due to #11357, where users would first see an empty list when the page loads since the CSI volume list didn't have support for wildcard querying.

Closes #11574

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vercel vercel bot temporarily deployed to Preview – nomad December 21, 2021 21:51 Inactive
@lgfa29 lgfa29 added this to the 1.2.4 milestone Dec 21, 2021
@lgfa29 lgfa29 merged commit 5abe007 into main Dec 21, 2021
@lgfa29 lgfa29 deleted the csi-list-wildcard branch December 21, 2021 22:19
@apollo13
Copy link
Contributor

@lgfa29 This probably also fixed #10939 ?

@tgross
Copy link
Member

tgross commented Jan 20, 2022

Yup, thanks @apollo13!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.1.x backport to 1.1.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSI volumes API doesn't respect wildcard namespace filter
3 participants