-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nomad eval list
command
#11675
nomad eval list
command
#11675
Conversation
Use the new filtering and pagination capabilities of the `Eval.List` RPC to provide filtering and pagination at the command line.
Also includes note that `nomad eval status -json` is deprecated and will be replaced with a single evaluation view in a future version of Nomad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, but looks great!
(also missing a changelog entry)
Co-authored-by: Luiz Aoqui <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a comment on an edge case for displaying the -per-page
help message, which seems like a quick fix so not a blocker. ✅ on this, good one!
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Use the new filtering and pagination capabilities of the
Eval.List
RPC (ref #11648) to provide filtering and pagination at the command line.