Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: set the job scale eval priority to the job priority. #11429

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Nov 2, 2021

Previously the eval priority was set to the default priority
rather than the priority configured within the target job. This
change fixes this bug, ensuring any eval created as a result of
scaling uses the job priority.

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrasell jrasell merged commit 8a8f119 into main Nov 5, 2021
@jrasell jrasell deleted the b-set-scale-eval-priority-correctly branch November 5, 2021 14:52
lgfa29 pushed a commit that referenced this pull request Nov 15, 2021
…rrectly

rpc: set the job scale eval priority to the job priority.
lgfa29 pushed a commit that referenced this pull request Nov 15, 2021
…rrectly

rpc: set the job scale eval priority to the job priority.
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants