Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: rename paths in debug bundle for clarity #11307

Merged
merged 5 commits into from
Oct 13, 2021
Merged

cli: rename paths in debug bundle for clarity #11307

merged 5 commits into from
Oct 13, 2021

Conversation

davemay99
Copy link
Contributor

This PR renames the following paths in the nomad operator debug bundle so that they more accurately reflect the contents:
Folders renamed:

  • version to cluster
  • nomad to interval
    File renamed:
  • plugins.json to csi-plugins.json

@davemay99 davemay99 requested a review from lgfa29 October 13, 2021 20:37
@vercel vercel bot temporarily deployed to Preview – nomad October 13, 2021 20:45 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad October 13, 2021 21:45 Inactive
lgfa29
lgfa29 approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a small commit to fix a test error and to make the test error output more clear to help debugging issues.

@davemay99 davemay99 merged commit 1d30caa into main Oct 13, 2021
@davemay99 davemay99 deleted the f-rename-debug-paths branch October 13, 2021 22:00
@davemay99 davemay99 added this to the 1.2.0 milestone Oct 13, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lgfa29 lgfa29 lgfa29 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@davemay99 @lgfa29