Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: task env vars should take precedence over host env vars. #11206

Merged
merged 2 commits into from
Sep 20, 2021
Merged

client: task env vars should take precedence over host env vars. #11206

merged 2 commits into from
Sep 20, 2021

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Sep 20, 2021

closes #11202

@jrasell jrasell added type/bug theme/client stage/accepted Confirmed, and intend to work on. No timeline committment though. labels Sep 20, 2021
@jrasell jrasell added this to the 1.2.0 milestone Sep 20, 2021
@jrasell jrasell self-assigned this Sep 20, 2021
lgfa29
lgfa29 approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missing a CHANGELOG entry 🙂

@vercel vercel bot temporarily deployed to Preview – nomad September 20, 2021 17:06 Inactive
@schmichael schmichael merged commit d7f9180 into main Sep 20, 2021
@schmichael schmichael deleted the b-gh-11202 branch September 20, 2021 18:22
schmichael added a commit that referenced this pull request Sep 20, 2021
@schmichael
Merge pull request #11206 from hashicorp/b-gh-11202
f59b81d 
client: task env vars should take precedence over host env vars.
schmichael added a commit that referenced this pull request Sep 20, 2021
@schmichael
Merge pull request #11206 from hashicorp/b-gh-11202
2a2317c 
client: task env vars should take precedence over host env vars.
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lgfa29 lgfa29 lgfa29 approved these changes

@schmichael schmichael schmichael approved these changes

Assignees

@jrasell jrasell

Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/client type/bug
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Host env vars take precendece over task env vars with exec/raw_exec
3 participants
@jrasell @schmichael @lgfa29