Fixed usage of NOMAD_CLI_NO_COLOR env variable.

[apollo13]

Fixes #10982

[lgfa29]

Thank you for looking into this and fixing it! It's weird that this env var was only being ignored in some commands 😅

I pushed a commit to add a CHANLOG entry and some tests. I also changed the logic a bit to read the command UI type and decide if colors should be disabled based on that. This will avoid having to check the env var in multiple places, since it's already being checked in main.go.

This change will also help with #10975, since I think you won't need to check for the new env var in Colorize. If that's indeed the case, could you update that PR?

Thanks again for the contribution!

[apollo13]

This change will also help with #10975, since I think you won't need to check for the new env var in Colorize. If that's indeed the case, could you update that PR?

Will do that over the following days. Your approach is certainly nicer -- my (none existent) go knowledge prevented me from knowing about that type cast/check thingy. Thanks for the edits.

[lgfa29]

Will do that over the following days. Your approach is certainly nicer -- my (none existent) go knowledge prevented me from knowing about that type cast/check thingy. Thanks for the edits.

We don't expect any Go knowledge and really appreciate your effort in fixing these issues 🙂

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.