Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: always set script checks hook #10403

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented Apr 19, 2021

Similar to a bugfix made for the services hook, we need to always
set the script checks hook, in case a task is initially launched
without script checks, but then updated to include script checks.

The scipt checks hook is the thing that handles that new registration.

Similar to a bugfix made for the services hook, we need to always
set the script checks hook, in case a task is initially launched
without script checks, but then updated to include script checks.

The scipt checks hook is the thing that handles that new registration.
@shoenig shoenig marked this pull request as ready for review April 19, 2021 22:10
@shoenig shoenig requested review from tgross and drewbailey April 19, 2021 22:10
Copy link
Contributor

@drewbailey drewbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@shoenig shoenig merged commit 2fc19c3 into main Apr 19, 2021
@shoenig shoenig deleted the b-always-set-scriptchecks-hook branch April 19, 2021 22:13
@tgross tgross added this to the 1.1.0 milestone May 17, 2021
tgross pushed a commit that referenced this pull request May 17, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants