From 3c8a7d3daf2e9b2f7b36b644f2cb3ecb1d3cf4db Mon Sep 17 00:00:00 2001 From: Michael Lange Date: Fri, 21 Aug 2020 18:44:13 -0700 Subject: [PATCH] Always show the scaling events accordion --- ui/app/templates/jobs/job/task-group.hbs | 18 +++++++++--------- ui/tests/acceptance/task-group-detail-test.js | 4 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/ui/app/templates/jobs/job/task-group.hbs b/ui/app/templates/jobs/job/task-group.hbs index 915e1337388..882a76b2077 100644 --- a/ui/app/templates/jobs/job/task-group.hbs +++ b/ui/app/templates/jobs/job/task-group.hbs @@ -147,16 +147,16 @@ - {{else}} -
-
- Recent Scaling Events -
-
- -
-
{{/if}} + +
+
+ Recent Scaling Events +
+
+ +
+
{{/if}} {{#if this.model.volumes.length}} diff --git a/ui/tests/acceptance/task-group-detail-test.js b/ui/tests/acceptance/task-group-detail-test.js index 82d42fd72ec..88c324dbe77 100644 --- a/ui/tests/acceptance/task-group-detail-test.js +++ b/ui/tests/acceptance/task-group-detail-test.js @@ -455,7 +455,7 @@ module('Acceptance | task group detail', function(hooks) { }); }); - test('when a task group has at least two count scaling events and the count scaling events outnumber the non-count scaling events, a timeline is shown instead of an accordion', async function(assert) { + test('when a task group has at least two count scaling events and the count scaling events outnumber the non-count scaling events, a timeline is shown in addition to the accordion', async function(assert) { const taskGroupScale = job.jobScale.taskGroupScales.models.find(m => m.name === taskGroup.name); taskGroupScale.update({ events: [ @@ -473,7 +473,7 @@ module('Acceptance | task group detail', function(hooks) { const scaleEvents = taskGroupScale.events.models.sortBy('time').reverse(); await TaskGroup.visit({ id: job.id, name: taskGroup.name }); - assert.notOk(TaskGroup.hasScaleEvents); + assert.ok(TaskGroup.hasScaleEvents); assert.ok(TaskGroup.hasScalingTimeline); assert.equal(