From aa330fc7b9c6a7f43e3cf3bfb754f2e0e37875dd Mon Sep 17 00:00:00 2001 From: Radek Simko Date: Fri, 16 Feb 2024 12:57:11 +0000 Subject: [PATCH 1/3] github: Rename workflow to reflect reality --- .github/workflows/{push.yml => checks.yml} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename .github/workflows/{push.yml => checks.yml} (98%) diff --git a/.github/workflows/push.yml b/.github/workflows/checks.yml similarity index 98% rename from .github/workflows/push.yml rename to .github/workflows/checks.yml index a16f7b6b..ce17f940 100644 --- a/.github/workflows/push.yml +++ b/.github/workflows/checks.yml @@ -1,4 +1,4 @@ -name: Per-commit Checks +name: Checks on: push: From 82351cc777eb4118a8ad348b9a7da831a4a2fa1d Mon Sep 17 00:00:00 2001 From: Radek Simko Date: Fri, 16 Feb 2024 12:57:36 +0000 Subject: [PATCH 2/3] github: Run unit tests on macos/amd64 as well --- .github/workflows/checks.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index ce17f940..4842b6e9 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -14,6 +14,8 @@ jobs: target: linux_amd64 - runs-on: windows-latest target: windows_amd64 + - runs-on: macos-latest + target: darwin_amd64 fail-fast: false name: "Unit Tests on ${{ matrix.target }}" From 97cf603f3cadfdcd5b472e55e2576ad22e971b17 Mon Sep 17 00:00:00 2001 From: Radek Simko Date: Fri, 16 Feb 2024 13:04:28 +0000 Subject: [PATCH 3/3] github: Read Go version from go.mod This reduces the number of places to update whenever we upgrade Go version. --- .github/workflows/checks.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index 4842b6e9..6aaa038b 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -34,7 +34,7 @@ jobs: - name: Install Go uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0 with: - go-version: 1.18 + go-version-file: go.mod - name: Go test run: | go test ./... -race @@ -49,7 +49,7 @@ jobs: - name: Install Go uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0 with: - go-version: 1.18 + go-version-file: go.mod - name: "Check vet" run: | go vet ./...