Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Defaults for idle connections #33

Closed
eikenb opened this issue Jan 11, 2021 · 1 comment
Closed

Review Defaults for idle connections #33

eikenb opened this issue Jan 11, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@eikenb
Copy link
Contributor

eikenb commented Jan 11, 2021

Related to: hashicorp/consul-terraform-sync#164

Review the defaults (if any) and consider applying the defaults CTS uses. These are the default values changed in CTS, as copied from Consul-template. See that ticket for details about why and impact of each change.

DefaultMaxIdleConnsPerHost: 1 -> 100
DefaultMaxIdleConns: 100 -> 0
DefaultIdleConnTimeout: 90s -> 5s
@eikenb eikenb added the enhancement New feature or request label Jan 11, 2021
@eikenb eikenb changed the title Review Defaults Review Defaults for idle connections Oct 12, 2021
@eikenb
Copy link
Contributor Author

eikenb commented Jul 21, 2022

Hashicat currently has no defaults and I think it is better this way. I think I was really thinking of consul-template when I suggested this as those are different than the defaults there. Going to re-open this ticket there.

@eikenb eikenb closed this as completed Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eikenb