Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint workflow #262

Merged
merged 19 commits into from
Sep 29, 2021
Merged

golangci-lint workflow #262

merged 19 commits into from
Sep 29, 2021

Commits on Sep 22, 2021

  1. draft golangci-lint workflow

    @uturunku1
    uturunku1 committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    3dd8ec4 View commit details
    Browse the repository at this point in the history

  2. fix gh action error that says every step must define a or key

    @uturunku1
    uturunku1 committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    222fe15 View commit details
    Browse the repository at this point in the history

  3. 1.42.1 is an invalid version

    @uturunku1
    uturunku1 committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    e8279f2 View commit details
    Browse the repository at this point in the history

  4. temporarily commenting the option only-new-issues to correct old issues

    @uturunku1
    uturunku1 committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    6bfaa45 View commit details
    Browse the repository at this point in the history

  5. apply golangci-lint recommendations: remove unused code which is ever… 

    …ything that was inside helper_test.go and remove unnecesary use of formatting
    @uturunku1
    uturunku1 committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    e14e068 View commit details
    Browse the repository at this point in the history

  6. add back file because its functions are being used, is just that gola… 

    …ngci-lint does not see it
    @uturunku1
    uturunku1 committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    08332ca View commit details
    Browse the repository at this point in the history

  7. add flag to ignore test files

    @uturunku1
    uturunku1 committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    9f58003 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2021

  1. add yml for golangci configuration and add setting to ignore unused f… 

    …unctions from test files
    @uturunku1
    uturunku1 committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    5b21f13 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2021

  1. remove extra lines

    @uturunku1
    uturunku1 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    13c20e5 View commit details
    Browse the repository at this point in the history

  2. pin to version 1.29 to compare behaviour with version 1.40

    @uturunku1
    uturunku1 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    413f623 View commit details
    Browse the repository at this point in the history

  3. enable some useful lint libraries and use go version 1.16 and golangc… 

    …i-lint 1.42 to match local environment
    @uturunku1
    uturunku1 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    3c44683 View commit details
    Browse the repository at this point in the history

  4. golangci-lint library recommends to stop using golint because it is d… 

    …eprecated and archive, and instead use revive: https://github.com/hashicorp/go-tfe/pull/262/checks?check_run_id=3738237150
    @uturunku1
    uturunku1 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    be0ed9d View commit details
    Browse the repository at this point in the history

  5. fix new issues point by golangci-lint

    @uturunku1
    uturunku1 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    771ab13 View commit details
    Browse the repository at this point in the history

  6. clarify comment on why we are not using golint

    @uturunku1
    uturunku1 committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    cabf350 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. enable other lint libraries that I liked their description and add ad… 

    …ditional configuration to errcheck because some of their features are disable by default
    @uturunku1
    uturunku1 committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    1689acd View commit details
    Browse the repository at this point in the history

  2. add configuration to golangci-lint and fix errors mentioned by enable… 

    …d lint libraries
    @uturunku1
    uturunku1 committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    a573060 View commit details
    Browse the repository at this point in the history

  3. remove not useful comments

    @uturunku1
    uturunku1 committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    2e17d84 View commit details
    Browse the repository at this point in the history

  4. match lowercase in tests

    @uturunku1
    uturunku1 committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    1cb63d4 View commit details
    Browse the repository at this point in the history

  5. missing test

    @uturunku1
    uturunku1 committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    8b80493 View commit details
    Browse the repository at this point in the history