Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Flight Icon Request: HashiCorp products #330

Closed
sabrinako opened this issue Nov 5, 2021 · 4 comments
Closed

Flight Icon Request: HashiCorp products #330

sabrinako opened this issue Nov 5, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@sabrinako
Copy link

Outline the use case for the new icon.
Waypoint utilizes the logos of various HC products throughout, and we're in the middle of adopting the Flight icon library.

If there's a similar existing icon, why isn't it a good fit? Please describe.
There isn't any HashiCorp product logos 😢

Additional context
Notable edge case is the Waypoint logo on the login screen which is larger than the 16 or 24 size dictated by Flight.

@sabrinako sabrinako added enhancement New feature or request triage triage issue to determine validity labels Nov 5, 2021
@heatherlarsen
Copy link
Contributor

@sabrinako Thanks for the request. Could you please add a screenshot or link showing the Waypoint edge case you mentioned?

@sabrinako
Copy link
Author

sabrinako commented Nov 10, 2021

Screen Shot 2021-11-10 at 3 12 08 PM

The Waypoint logo in the middle of the screen is the edge case I mentioned! @heatherlarsen

@amyrlam
Copy link
Contributor

amyrlam commented Dec 7, 2021

Cross-posting this PR from @didoo, may complete the issue? #341

@didoo
Copy link
Contributor

didoo commented Dec 7, 2021

@amyrlam yes, you're right! I completely forgot about this particular open issue! I am closing it now.

@sabrinako FYI the product icons are now available both in Figma (as Flight Icons, usual standard library) as well as in code (version 2.0.0 of the icons, in which case careful is a breaking change)

@didoo didoo closed this as completed Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants