Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: improve the file safety of 'consul tls' subcommands #7186

Merged
merged 3 commits into from
Jan 31, 2020
Merged

cli: improve the file safety of 'consul tls' subcommands #7186

merged 3 commits into from
Jan 31, 2020

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Jan 30, 2020 •
edited
Loading

  • Also this adds more tests for consul tls ca create and consul tls cert create.
  • improved the signature of file.WriteAtomicWithPerms. Previously the perms arg was unexpectedly used for the os.Mkdirs call and not the file create call.

@rboyer rboyer requested a review from a team January 30, 2020 21:34
@rboyer rboyer self-assigned this Jan 30, 2020
@rboyer rboyer requested a review from hanshasselberg January 30, 2020 21:36
@rboyer rboyer mentioned this pull request Jan 30, 2020
Merged
9 tasks
hanshasselberg
hanshasselberg approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@hanshasselberg hanshasselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 👍

@rboyer rboyer merged commit cf29bd4 into master Jan 31, 2020
@rboyer rboyer deleted the improve-tls-cli-safety branch January 31, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanshasselberg hanshasselberg hanshasselberg approved these changes

Assignees

@rboyer rboyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rboyer @hanshasselberg