Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -format=json flag to the ACL CLI commands #7141

Closed
mkeeler opened this issue Jan 27, 2020 · 1 comment
Closed

Add -format=json flag to the ACL CLI commands #7141

mkeeler opened this issue Jan 27, 2020 · 1 comment
Labels
good first issue A well-defined bug or improvement with sufficient context which should be approachable for new contr help-wanted We encourage community PRs for these issues! theme/acls ACL and token generation theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner type/enhancement Proposed improvement or new feature

Comments

@mkeeler
Copy link
Member

mkeeler commented Jan 27, 2020

Feature Description

After reviewing some of the upcoming guide updates for ACLs it seemed like allowing these CLI commands to output the JSON response instead of the normal formatting might be better in some cases. This would be particularly useful if we want to post-process the result with jq or some other tool to grab a token secret or policy id.

This request is to add a -format option that defaults to pretty (our default format) but has the option to be specified as json and in that case we will just output the JSON response.
@mkeeler mkeeler added type/enhancement Proposed improvement or new feature theme/acls ACL and token generation theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner good first issue A well-defined bug or improvement with sufficient context which should be approachable for new contr help-wanted We encourage community PRs for these issues! labels Jan 27, 2020
@mullakhmetov mullakhmetov mentioned this issue Feb 2, 2020
Merged
@mullakhmetov
Copy link
Contributor

@mkeeler could you please review my attempt? #7198

@mkeeler mkeeler closed this as completed Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A well-defined bug or improvement with sufficient context which should be approachable for new contr help-wanted We encourage community PRs for these issues! theme/acls ACL and token generation theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner type/enhancement Proposed improvement or new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkeeler @mullakhmetov