Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please update "github.com/miekg/dns" #6984

Closed
onlyjob opened this issue Dec 30, 2019 · 2 comments · Fixed by #7252
Closed

Please update "github.com/miekg/dns" #6984

onlyjob opened this issue Dec 30, 2019 · 2 comments · Fixed by #7252

Comments

@onlyjob
Copy link

onlyjob commented Dec 30, 2019

github.com/miekg/dns v1.1.26 fixes CVE-2019-19794 but also introduces a regression due to removal of ErrTruncated which causes the following FTBFS in Consul:

src/github.com/hashicorp/consul/agent/dns.go:1592:34: undefined: dns.ErrTruncated

Please consider upgrading github.com/miekg/dns. Thanks.
@mkeeler mkeeler mentioned this issue Feb 10, 2020
Merged
@onlyjob
Copy link
Author

onlyjob commented Feb 10, 2020 •
edited
Loading

Thanks, @mkeeler. Did you have to make any changes to agent/dns.go in order to accommodate updated 'miekg/dns` and fix FTBFS?

@hanshasselberg
Copy link
Member

After you created the issue, we updated to a more recent version and made the changes at that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to miekg/dns v1.1.26 hashicorp/consul
2 participants
@hanshasselberg @onlyjob