Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agent: allow mesh gateways to initialize even if there are no connect services registered yet #6576

Merged
merged 3 commits into from
Oct 17, 2019
Merged

agent: allow mesh gateways to initialize even if there are no connect services registered yet #6576

merged 3 commits into from
Oct 17, 2019

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Oct 3, 2019

Fixes #6543

Also improved some of the proxycfg tests to cover snapshot validity better.

@rboyer
agent: allow mesh gateways to initialize even if there are no connect…
4c7ff62 
… services registered yet

Fixes #6543

Also improved some of the proxycfg tests to cover snapshot validity
better.
@rboyer rboyer added theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies backport/1.6 labels Oct 3, 2019
@rboyer rboyer requested a review from a team October 3, 2019 15:09
@rboyer rboyer self-assigned this Oct 3, 2019
mkeeler
mkeeler reviewed Oct 3, 2019
View reviewed changes
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any tests we could/should add to the xDS package golden file tests to ensure the Mesh Gateway configuration delivered to Envoy will be correct in the case where the snapshot IsEmpty?

@rboyer
Copy link
Member Author

rboyer commented Oct 3, 2019

I added tests for the xds golden tests. The Valid method being a gatekeeper for returning complete configs is in the grey area between the proxycfg and xds packages. The tests I just added verify that assuming the Valid method does return true with no services it generates something sane.

@rboyer rboyer requested a review from mkeeler October 3, 2019 19:25
mkeeler
mkeeler approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rboyer rboyer merged commit 97aa050 into master Oct 17, 2019
rboyer added a commit that referenced this pull request Oct 17, 2019
@rboyer
agent: allow mesh gateways to initialize even if there are no connect…
0be3324 
… services registered yet (#6576)

Fixes #6543

Also improved some of the proxycfg tests to cover snapshot validity
better.
@rboyer rboyer deleted the empty-mwg-ok branch October 17, 2019 21:47
rboyer added a commit that referenced this pull request Nov 13, 2019
@rboyer
xds: mesh gateway CDS requests are now allowed to receive an empty CD…
0ddcd46 
…S reply

This is the rest of the fix for #6543 that was incompletely fixed in #6576.
@rboyer rboyer mentioned this pull request Nov 13, 2019
Merged
rboyer added a commit that referenced this pull request Nov 25, 2019
@rboyer
xds: mesh gateway CDS requests are now allowed to receive an empty CD…
1174b2f 
…S reply

This is the rest of the fix for #6543 that was incompletely fixed in #6576.
rboyer added a commit that referenced this pull request Nov 26, 2019
@rboyer
xds: mesh gateway CDS requests are now allowed to receive an empty CD…
2011f3d 
…S reply (#6787)

This is the rest of the fix for #6543 that was incompletely fixed in #6576.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkeeler mkeeler mkeeler approved these changes

Assignees

@rboyer rboyer

Labels
theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mesh Gateway starts "unhealthy" when no other service is registered in local Consul DC
2 participants
@rboyer @mkeeler