-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
acl: ACL Tokens can now be assigned an optional set of service identities #5390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rboyer
added
theme/acls
ACL and token generation
theme/connect
Anything related to Consul Connect, Service Mesh, Side Car Proxies
labels
Feb 26, 2019
rboyer
force-pushed
the
f-token-expiration
branch
from
February 27, 2019 17:13
f331c42
to
4079224
Compare
rboyer
force-pushed
the
f-acl-service-identities
branch
from
February 27, 2019 17:14
8a8fe93
to
d4d39d1
Compare
rboyer
force-pushed
the
f-token-expiration
branch
from
March 1, 2019 20:51
4079224
to
8e9b063
Compare
rboyer
force-pushed
the
f-acl-service-identities
branch
2 times, most recently
from
March 4, 2019 20:28
024c5e6
to
26b9c9a
Compare
rboyer
force-pushed
the
f-token-expiration
branch
from
March 5, 2019 21:17
28a87ac
to
c756611
Compare
rboyer
force-pushed
the
f-acl-service-identities
branch
from
March 5, 2019 21:24
26b9c9a
to
d7ee9b3
Compare
rboyer
force-pushed
the
f-token-expiration
branch
from
March 14, 2019 15:29
c756611
to
473db0d
Compare
rboyer
force-pushed
the
f-acl-service-identities
branch
from
March 14, 2019 15:36
d7ee9b3
to
523289b
Compare
mkeeler
approved these changes
Mar 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
banks
approved these changes
Apr 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High-level read through 👍
rboyer
force-pushed
the
f-token-expiration
branch
from
April 1, 2019 16:44
ff0f4c0
to
e9439b5
Compare
rboyer
force-pushed
the
f-acl-service-identities
branch
from
April 1, 2019 16:44
523289b
to
1f0bdd9
Compare
rboyer
force-pushed
the
f-acl-service-identities
branch
from
April 8, 2019 17:15
1f0bdd9
to
c70a096
Compare
…ties These act like a special cased version of a Policy Template for granting a token the privileges necessary to register a service and its connect proxy, and read upstreams from the catalog.
rboyer
force-pushed
the
f-acl-service-identities
branch
from
April 8, 2019 17:18
c70a096
to
7951e92
Compare
rboyer
added a commit
that referenced
this pull request
Apr 24, 2019
…ties (#5390) These act like a special cased version of a Policy Template for granting a token the privileges necessary to register a service and its connect proxy, and read upstreams from the catalog.
rboyer
added a commit
that referenced
this pull request
Apr 26, 2019
…ties (#5390) These act like a special cased version of a Policy Template for granting a token the privileges necessary to register a service and its connect proxy, and read upstreams from the catalog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
theme/acls
ACL and token generation
theme/connect
Anything related to Consul Connect, Service Mesh, Side Car Proxies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent PR: #5353
Note: this is merging into a long lived feature branch, not master. Future PRs in this series may adjust the contents here slightly as needed. These are separated out for digestibility.
These act like a special cased version of a Policy Template for granting a token the privileges necessary to register a service and its connect proxy, and read upstreams from the catalog.