-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a helper for generating Consul's user-agent string #4013
Conversation
@sethvargo Thanks for the PR. Do you have ideas already for places in the consul code where you think this new function should be used? |
Right now, nowhere 😄 Once hashicorp/go-discover#33 is merged, it'll be when Consul makes external API calls. I would also like if Consul set its user agent when invoking health checks, but there's already a hard-coded user-agent string, and I don't know the implications of changing that. Ideally (external) services would like to know more about Consul and the chain, but I don't know if we can change that for BC. |
Yeah I think we should think separately about the heath check change for the reasons you mention but we should be able to get this and the corresponding go-discover change in for the release following 1.0.7. |
Hey @pearkes - I updated this PR to pull in the new lib and connect it all at once. I'm not sure why there are so many changes to vendor. I ran |
Thanks @sethvargo -- yeah I think this will also fix #4082, FYI @preetapan. |
@sethvargo thanks for your patience on this! We got the vendor changes in a separate change, so do you mind rebasing which should just include the changes required to set the user agents in the go-discover clients? |
Updated @pearkes. I'm not sure why there's still some whitespacing diffs on three of the vendor files, but I also don't know how to fix it. Hopefully that's okay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is not currently used, but it should be. Refs hashicorp/go-discover#33
/cc @pearkes