-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service Registration/De-registration slows down due to existing services with expired token. #3363
Comments
Hi @ars05 for the "Register another service" do you use the same expired token or a valid one? |
Hi @slackpad - We do use a new valid token for service registration. The "another service" is being registered with a newly generated consul token. |
I've got a theory about this one since you are restarting the Consul node, and some of the token tracking is in-process and won't survive a restart. Seems possibly related to #3676. |
Yes, we definitely have the same issue #3676 The checks are not updated nor the new services. This is very problematic for us since our service registration is a on-demand one. In some case, we even have to clean up everything (all services/checks) in the local agent in order to make it converge again |
@ars05 I'm aware it's been a while and you may no longer be able to say, but are you able to confirm that the issue described in #3676 and it's resolution in #4771 solve the issue here? The tl;dr is that if you are using If so we can close this issue in favour, I just wasn't certain enough that we confirmed the same diagnosis here before I do that. |
The fix for #3676 was merged and should protect against individual check/service registration failures due to ACL not found errors impacting other check/service registration. The problem was that for not found errors (not permission denied) they were being treated as other server errors and would abort various loops and prevent other service/check registrations. The fix is to ensure that not found errors are treated like permission denied errors which will then only affect that single check/service. @ars05 Its been a while since @banks question so I am going to close this. If a similar situation crops up again please open a new issue. |
consul version
for both Client and ServerClient:
Consul v0.8.5
Server:
Consul v0.8.5
Operating system and Environment details
CentOS Linux release 7.3.1611 (Core)
Description of the Issue (and unexpected/desired result)
The token for services registered with clients expires after a while depend on the TTL, then services without valid tokens generating error:
[ERR] consul: RPC failed to server IP:8300: rpc error: rpc error: ACL not found
[ERR] agent: failed to sync changes: rpc error: rpc error: ACL not found
and service registration/de-registration takes a very long time.
Reproduction steps
The text was updated successfully, but these errors were encountered: