-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Service check flap detection #2890
Comments
Any idea when this enhancement is going to be part of consul. Thanks |
Any eyes still on this? |
+1 |
2 similar comments
+1 |
+1 |
bump |
+1 |
+1 |
4 similar comments
+1 |
+1 |
+1 |
+1 |
This is a great feature suggestions and it's being tracked. I'd like to encourage folks to use 👍 reaction emoji on the issue to indicate that it's a popular request as that's a really useful signal for us. +1 comments on the other hand make discussion harder and add frustrating noise to our message inboxes and we tend not to count them so actually give less good indication of how important this is to you all! If anyone has additional data they think will help guide or prioritise this feature, or want's to look into contributing a PR by proposing a solution we'd love to hear from you of course! At this time we don't have firm plans for when we'll consider this request but it's on our radar. |
@kyhavlov when is this gonna be in consul, cause i need it, and you are the best and stuffffff, do you take bribes ? |
Wondering with #5739 if that satisfies all the original ask. Shipped in Consul 1.7 I believe. https://www.consul.io/docs/agent/checks.html#success-failures-before-passing-critical |
I believe it should @unicell - Thanks for the update. |
Hey there, This issue has been automatically locked because it is closed and there hasn't been any activity for at least 30 days. If you are still experiencing problems, or still have questions, feel free to open a new one 👍. |
Feature
Occasionally we have services where their states are flapping causing slight disruptions to the overall availability of our platform. From what I can see Consul doesn't provide any flap detection (Please correct me if I'm wrong) at the moment for service health checks.
It would be an excellent feature for Consul to have, seeing as (if configured) most services will have health checks configured with Consul, putting it in the ideal position for it to handle flap detection.
When services health checks are registered, one could simply provide the flap-threshold and time-span on which it needs to exceed before the service is marked as critical. The same threshold and time-span could also be used to indicate when a service is no longer flapping, marking the service as passing.
I'm not sure how up to date this document is, but this is how Nagios tackles it.
The text was updated successfully, but these errors were encountered: