Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if invalid service name according to RFC-1123 and RFC-2782 #1830

Closed
sean- opened this issue Mar 15, 2016 · 1 comment
Closed

Warn if invalid service name according to RFC-1123 and RFC-2782 #1830

sean- opened this issue Mar 15, 2016 · 1 comment
Labels
type/bug Feature does not function as expected type/enhancement Proposed improvement or new feature

Comments

@sean-
Copy link
Contributor

sean- commented Mar 15, 2016

Similar to the error installed in nomad#915, Consul should warn when a service name is registered that is invalid. Valid service names are only allowed to begin and end in alphanumeric characters, may contain alphanum or hyphens, and must be shorter than64 characters in length.
@sean- sean- added type/bug Feature does not function as expected type/enhancement Proposed improvement or new feature easy labels Mar 15, 2016
@sean- sean- added this to the 0.7 milestone Mar 15, 2016
This was referenced Mar 15, 2016
Closed
Closed
@slackpad slackpad removed this from the 0.7 milestone Oct 25, 2016
@slackpad
Copy link
Contributor

Since there are non-DNS users using services like this already, we've decided to not do this. Folks were concerned this would be a noisy change, and it's not worth adding a configuration to disable the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Feature does not function as expected type/enhancement Proposed improvement or new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sean- @slackpad