Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug/Gostring output of VaultConfig causes nil pointer reference panic #1586

Closed
eikenb opened this issue Jun 7, 2022 · 1 comment
Closed

Debug/Gostring output of VaultConfig causes nil pointer reference panic #1586

eikenb opened this issue Jun 7, 2022 · 1 comment
Labels
bug
Milestone
v0.29.2

Comments

@eikenb
Copy link
Contributor

eikenb commented Jun 7, 2022

In VaultConfig's GoString() method it references *c.LeaseRenewalThreshhold, but c can be nil and, if so, this panics. It should use a FloatGoString() method (similar to the others in config/convert.go) to get the value with the check for nil.
@eikenb eikenb added the bug label Jun 7, 2022
@eikenb eikenb added this to the v0.30.0 milestone Jul 15, 2022
@eikenb eikenb modified the milestones: v0.30.0, v0.29.2 Aug 1, 2022
@eikenb
Copy link
Contributor Author

eikenb commented Aug 15, 2022

This was fixed in 073eb94

@eikenb eikenb closed this as completed Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.29.2
Development

No branches or pull requests
1 participant
@eikenb