Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul-template master branch does not respect log levels #1426

Closed
jjjordan opened this issue Nov 18, 2020 · 2 comments
Closed

consul-template master branch does not respect log levels #1426

jjjordan opened this issue Nov 18, 2020 · 2 comments
Labels
bug
Milestone
0.25.2

Comments

@jjjordan
Copy link

jjjordan commented Nov 18, 2020 •
edited
Loading

Running consul-template in master results in trace output regardless of what log level is configured. This appears to have been caused by 4caec4d, specifically here where the LevelFilter is completely disregarded.
@eikenb eikenb added the bug label Nov 18, 2020
@eikenb
Copy link
Contributor

eikenb commented Nov 18, 2020

@jjjordan thanks for reporting this.. points out a lack of testing around logging. We should fix that when we fix this.

@eikenb eikenb added this to the 0.25.2 milestone Nov 18, 2020
@eikenb
Copy link
Contributor

eikenb commented Feb 18, 2021

Opps... missed this one when I fixed this in #1454, which overwrote the normal log filter with just dumping everything out, ignoring the log level.

Anyways, it should be fixed.

@eikenb eikenb closed this as completed Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.25.2
Development

No branches or pull requests
2 participants
@jjjordan @eikenb