change dedup to use one key and do auto-cleanup of the dedup kv store #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@bofm Thanks for the contribution. We'd like to land it with a few minor changes, but are you able to sign the CLA? |
|
I don't want to sign it. What would you like to change in the implementation? |
kyhavlov
reviewed
Feb 19, 2019
manager/dedup.go
Outdated
| @@ -32,7 +32,8 @@ const ( | |||
|
|
|||
| // templateDataFlag is added as a flag to the shared data values | |||
| // so that we can use it as a sanity check | |||
| templateDataFlag = 0x22b9a127a2c03520 | |||
| templateDataFlag = 0x22b9a127a2c03520 | |||
There was a problem hiding this comment.
This can get removed now since it's not used anywhere.
|
Can you please re-run the tests |
|
All signed. Can it be merged? |
|
Merged and will be part of upcoming release. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed deduplication to achieve the following:
consul-template/dedup/<md5>/datafixes #1158