Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect proxy uses wrong service id #163

Closed
lkysow opened this issue Nov 8, 2019 · 0 comments · Fixed by #172
Closed

Connect proxy uses wrong service id #163

lkysow opened this issue Nov 8, 2019 · 0 comments · Fixed by #172
Labels
area/connect Related to Connect service mesh, e.g. injection type/bug Something isn't working

Comments

@lkysow
Copy link
Member

lkysow commented Nov 8, 2019

The service ID is set here:

services {
id = "${POD_NAME}-{{ .ServiceName }}"
name = "{{ .ServiceName }}"

to "${POD_NAME}-{{ .ServiceName }}". However the proxy config doesn't use the correct destination_service_id and just uses {{.ServiceName}}:

proxy {
destination_service_name = "{{ .ServiceName }}"
destination_service_id = "{{ .ServiceName }}"

This doesn't seem to break Connect, however it breaks the links in the UI where the Dest. service instance results in a 404 since it links to static-client instead of static-client-static-client:
image

@lkysow lkysow added area/connect Related to Connect service mesh, e.g. injection type/bug Something isn't working labels Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connect Related to Connect service mesh, e.g. injection type/bug Something isn't working
Projects
None yet
1 participant