Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server-acl-init should be idempotent #138

Closed
lkysow opened this issue Sep 18, 2019 · 0 comments · Fixed by #143
Closed

server-acl-init should be idempotent #138

lkysow opened this issue Sep 18, 2019 · 0 comments · Fixed by #143
Labels
area/acls Related to ACLs type/enhancement New feature or request

Comments

@lkysow
Copy link
Member

lkysow commented Sep 18, 2019

Currently, if any step in the server-acl-init command fails, then when the command is re-run it will never succeed.

This is because it first tries to bootstrap the ACL system. If it's already been bootstrapped then this will fail and the command will exit without performing the rest of its tasks (creating other acl tokens).

Not only should it be idempotent but it should continue executing until its completed its job. If it can't connect to Consul servers or it gets an error it should just retry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/acls Related to ACLs type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant