Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

support for prefixes when registering in Consul #140

Closed
kgignatyev-inspur opened this issue Mar 22, 2019 · 2 comments
Closed

support for prefixes when registering in Consul #140

kgignatyev-inspur opened this issue Mar 22, 2019 · 2 comments

Comments

@kgignatyev-inspur
Copy link

It would be nice if it was possible to specify ConsulPrefix for Kubernetes -> Consul sync, the same way as it is possible to specify k8sPrefix for Consul->Kubernetes sync.
Purpose: easily register all services while disambiguating services with common names which belong to different clusters.

Rational: lets say we have 2 k8s clusters in a single data center, they might be running many 'system' services liker rook, kubernetes, etc. Which we would like to register with Consul, but current behavior will create pool of nodes belonging to different clusters under the same service name, which is not desirable. It would be better to use ConsulPrefix to create names like prefix1-rook and prefix2-rook for services with the same names running in different clusters when syncCatalog.default=true. Annotations would allow to use current behavior: services will have common name (unprefixed) and instances running on different clusters will still be registered under single name in Consul.

@adilyse
Copy link
Contributor

adilyse commented Apr 11, 2019

Hi @kgignatyev-inspur,

I agree, it makes sense to allow this functionality in both directions. This feature is currently under development and should be available soon.

@adilyse
Copy link
Contributor

adilyse commented May 1, 2019

This functionality has been added and will be available in the next release, v0.8.0, which will be released soon. Details of the implementation can be seen here: consul-k8s, consul-helm.

Thanks for helping make this a better product!

@adilyse adilyse closed this as completed May 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants