Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executeTransaction does not return receipt when signing an AccountCreateTransaction #337

Open
rocketmay opened this issue Nov 13, 2024 · 1 comment · May be fixed by #339
Open

executeTransaction does not return receipt when signing an AccountCreateTransaction #337

rocketmay opened this issue Nov 13, 2024 · 1 comment · May be fixed by #339

Comments

@rocketmay
Copy link

AccountCreateTransaction executeTransaction() Not Returning Receipt

Bug Description

The executeTransaction() function does not return a receipt when signing an AccountCreateTransaction. While the transaction successfully executes on the ledger, the async function doesn't return anything, contrary to expected behavior.

Steps to Reproduce

  1. Create an AccountCreateTransaction (tested with threshold key, non-threshold keys untested)
  2. Freeze the transaction
  3. Execute the transaction
const transaction = new AccountCreateTransaction()
    .setKey(thresholdKey)
    .setAccountMemo("");
const frozen = await transaction.freezeWithSigner(signer);
const receipt = await walletConnect.executeTransaction(frozen);

The transaction can be verified as successful on Hashscan by checking the signer account, but executeTransaction never returns. After several minutes, the following error is caught:

{
  "txError": {},
  "queryError": {
    "name": "Error",
    "message": "(BUG) Query.fromBytes() not implemented for type getByKey",
    "stack": "Error: (BUG) Query.fromBytes() not implemented for type getByKey
    at Query.fromBytes (webpack-internal:///(app-pages-browser)/./node_modules/@hashgraph/sdk/src/query/Query.js:138:19)
    at DAppSigner._tryExecuteQueryRequest (webpack-internal:///(app-pages-browser)/./node_modules/@hashgraph/hedera-wallet-connect/dist/src/lib/dapp/DAppSigner.js:191:77)
    at DAppSigner.call (webpack-internal:///(app-pages-browser)/./node_modules/@hashgraph/hedera-wallet-connect/dist/src/lib/dapp/DAppSigner.js:211:40)
    at async HashinalsWalletConnectSDK.executeTransaction (webpack-internal:///(app-pages-browser)/./node_modules/@hashgraphonline/hashinal-wc/dist/es/hashinal-wc.es.js:1938:26)
    }"
  }
}

Expected Behavior

executeTransaction should return a receipt after the transaction is executed.

Environment

OS: Linux
Browser: Chrome (using Chrome HashPack extension)
HashPack Version: 11.0.2

@kantorcodes
Copy link
Contributor

We've confirmed the following PR fixes this: #339 (canary: 1.3.7-canary.813a6d2.0)

Will close once merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants