Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Updating the build workflow to use Codecov actions instead of codecov npm package. #2558

Merged
merged 12 commits into from
Oct 4, 2024

Conversation

san-est
Copy link
Contributor

@san-est san-est commented Oct 3, 2024

Description:
There is an issue with the build workflow so this modifies it to use the official codecov action to try and resolve the issue.

Related issue(s):

Fixes #2557

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@san-est san-est added the github_actions Pull requests that update GitHub Actions code label Oct 3, 2024
@san-est san-est added this to the v2.53.0 milestone Oct 3, 2024
@san-est san-est self-assigned this Oct 3, 2024
@san-est san-est linked an issue Oct 3, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.40%. Comparing base (5c428d4) to head (1a89506).
Report is 143 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2558      +/-   ##
==========================================
+ Coverage   76.49%   84.40%   +7.90%     
==========================================
  Files         304      283      -21     
  Lines       75800    70929    -4871     
==========================================
+ Hits        57986    59868    +1882     
+ Misses      17814    11061    -6753     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agadzhalov agadzhalov marked this pull request as ready for review October 4, 2024 07:50
@agadzhalov agadzhalov requested review from a team as code owners October 4, 2024 07:50
Copy link

sonarqubecloud bot commented Oct 4, 2024

@agadzhalov agadzhalov mentioned this pull request Oct 4, 2024
2 tasks
Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivaylonikolov7 ivaylonikolov7 merged commit 8bf5b24 into main Oct 4, 2024
13 checks passed
@ivaylonikolov7 ivaylonikolov7 deleted the 2557-ci-fix-codecov-issues-in-ci-workflow branch October 4, 2024 14:06
@agadzhalov agadzhalov modified the milestones: v2.53.0, v2.52.0 Oct 4, 2024
This was referenced Oct 7, 2024
b-l-u-e pushed a commit to b-l-u-e/hedera-sdk-js that referenced this pull request Oct 13, 2024
…ecov npm package. (hiero-ledger#2558)

* ci: Updating the build workflow to use Codecov actions instead of codecov npm package.

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* ci: Attempting a workaround for lcov.info missing.

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* ci: Commenting out long running jobs to try and troubleshoot.

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* ci: Troubleshooting folder contents

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* ci: testing with different task

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* ci: Adding in back Node start and stop

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* ci: Editing the tasks and testing again

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* ci: changing from c8 to nyc

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* ci: removing one more npx codecov for troubleshooting

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* ci: Re-enable integration and final job changes.

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* ci: reverting back to c8 from nyc

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* Removing .nycrc.json as its no longer needed.

Signed-off-by: Vasil Boyadzhiev <[email protected]>

---------

Signed-off-by: Vasil Boyadzhiev <[email protected]>
Signed-off-by: Vasil Boyadzhiev <[email protected]>
Signed-off-by: b-l-u-e <[email protected]>
b-l-u-e pushed a commit to b-l-u-e/hedera-sdk-js that referenced this pull request Oct 13, 2024
…ecov npm package. (hiero-ledger#2558)

* ci: Updating the build workflow to use Codecov actions instead of codecov npm package.

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* ci: Attempting a workaround for lcov.info missing.

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* ci: Commenting out long running jobs to try and troubleshoot.

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* ci: Troubleshooting folder contents

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* ci: testing with different task

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* ci: Adding in back Node start and stop

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* ci: Editing the tasks and testing again

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* ci: changing from c8 to nyc

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* ci: removing one more npx codecov for troubleshooting

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* ci: Re-enable integration and final job changes.

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* ci: reverting back to c8 from nyc

Signed-off-by: Vasil Boyadzhiev <[email protected]>

* Removing .nycrc.json as its no longer needed.

Signed-off-by: Vasil Boyadzhiev <[email protected]>

---------

Signed-off-by: Vasil Boyadzhiev <[email protected]>
Signed-off-by: Vasil Boyadzhiev <[email protected]>
Signed-off-by: b-l-u-e <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Fix codecov issues in Ci workflow
4 participants