Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide integration tests and example around NFT allowances #1469

Closed
petreze opened this issue Feb 21, 2023 · 0 comments · Fixed by #1468
Closed

Provide integration tests and example around NFT allowances #1469

petreze opened this issue Feb 21, 2023 · 0 comments · Fixed by #1468
Assignees
@petreze
Labels
enhancement New feature or request
Milestone
2.22.0

Comments

@petreze
Copy link
Contributor

petreze commented Feb 21, 2023

Problem

The SDK does not have any examples or integration tests showing the functionalities around HIP-336

Given the concept around the ERC standard that Hedera implements in regards to the allowances for NFTs it is crucial to have this shown in the SDK

Users cannot:

  • approve allowance for all serials in a NFT collection, then remove allowance for individual serial of the NFT
  • approve allowance for individual serial of the NFT, then remove allowance for all serials in the NFT collection

Solution

Show functionalities around approve/delete an allowance for:

  • single NFT serial numbers
  • all serial numbers at once
  • delegating spender obligations

Alternatives

No response
@petreze petreze added the enhancement New feature or request label Feb 21, 2023
@petreze petreze self-assigned this Feb 21, 2023
@petreze petreze linked a pull request Feb 21, 2023 that will close this issue
Feature nft allowance tests #1468
Merged
2 tasks
@petreze petreze mentioned this issue Feb 21, 2023
Merged
2 tasks
@Petyo-Lukanov Petyo-Lukanov added this to the 2.21.0 milestone Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petreze petreze

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.22.0
Development

Successfully merging a pull request may close this issue.

Feature nft allowance tests hashgraph/hedera-sdk-js
2 participants
@petreze @Petyo-Lukanov