Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRPC-WEB Proxies needs to be monitored and put as healthy/unhealthy #1363

Closed
ochikov opened this issue Jan 11, 2023 · 1 comment · Fixed by #1395
Closed

GRPC-WEB Proxies needs to be monitored and put as healthy/unhealthy #1363

ochikov opened this issue Jan 11, 2023 · 1 comment · Fixed by #1395
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ochikov
Copy link
Contributor

ochikov commented Jan 11, 2023

Description

If we get some kind of an HTTP ERROR CODE from the grpc-web-proxy, currently the SDK is design to watch only for headers labeled: grpc-status and grpc-message and thus we cannot catch the empty headers with the empty response but with HTTP ERROR CODE errors, so we cannot mark this web-proxy as unhealthy.

Steps to reproduce

  1. Create react-app
  2. Connect the client to MHW web-proxy
  3. Try to execute transaction
  4. Get 503

Additional context

Here are the only two headers that we are currently watching:
https://github.com/hashgraph/hedera-sdk-js/blob/develop/src/channel/WebChannel.js#L71

Hedera network

mainnet, testnet, previewnet

Version

v2.19.1

Operating system

macOS

@ochikov ochikov added the bug Something isn't working label Jan 11, 2023
@petreze petreze mentioned this issue Jan 13, 2023
2 tasks
@petreze
Copy link
Contributor

petreze commented Jan 16, 2023

Fixed with the following PR. Closed

@petreze petreze closed this as completed Jan 16, 2023
@petreze petreze linked a pull request Jan 16, 2023 that will close this issue
2 tasks
@Petyo-Lukanov Petyo-Lukanov added this to the 2.20.0 milestone Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants