Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The .bump-version.js needs to include the root level package.json file. #3220

Closed
ebadiere opened this issue Nov 5, 2024 · 0 comments · Fixed by #3221
Closed

The .bump-version.js needs to include the root level package.json file. #3220

ebadiere opened this issue Nov 5, 2024 · 0 comments · Fixed by #3221
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ebadiere
Copy link
Contributor

ebadiere commented Nov 5, 2024

Description

With the new ConfigService the package version number is required in order to run the web3_method. Once required, it was needed at the root level package.json to load the test framework, so it was added. Now the .bump-version.js script needs to include the root level package.json to update the application's version number.

Steps to reproduce

  1. From root run, "npm run bump-version --semver="some.version.number"
  2. Notice that the root level version: in the package.json is not updated.

Additional context

No response

Hedera network

testnet

Version

v.0.59.2

Operating system

Linux

@ebadiere ebadiere added the bug Something isn't working label Nov 5, 2024
@ebadiere ebadiere added this to the 0.59.0 milestone Nov 5, 2024
@ebadiere ebadiere self-assigned this Nov 5, 2024
@ebadiere ebadiere moved this from Backlog to Sprint Backlog in Smart Contract Sprint Board Nov 5, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Smart Contract Sprint Board Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant