diff --git a/postprocessors/imp_rec/imp_reconstructor.cpp b/postprocessors/imp_rec/imp_reconstructor.cpp index de6754fa..0fa51359 100644 --- a/postprocessors/imp_rec/imp_reconstructor.cpp +++ b/postprocessors/imp_rec/imp_reconstructor.cpp @@ -198,7 +198,7 @@ pesieve::ImpReconstructor::t_imprec_res pesieve::ImpReconstructor::rebuildImport return IMP_RECOVERY_ERROR; } -bool pesieve::ImpReconstructor::printFoundIATs(std::string reportPath) +bool pesieve::ImpReconstructor::printFoundIATs(const std::string& reportPath) { if (!foundIATs.size()) { return false; diff --git a/postprocessors/imp_rec/imp_reconstructor.h b/postprocessors/imp_rec/imp_reconstructor.h index 9d94cf58..fd56cfe7 100644 --- a/postprocessors/imp_rec/imp_reconstructor.h +++ b/postprocessors/imp_rec/imp_reconstructor.h @@ -198,7 +198,7 @@ namespace pesieve { t_imprec_res rebuildImportTable(const IN peconv::ExportsMapper* exportsMap, IN const pesieve::t_imprec_mode &imprec_mode); - bool printFoundIATs(std::string reportPath); + bool printFoundIATs(const std::string &reportPath); private: diff --git a/scanners/code_scanner.cpp b/scanners/code_scanner.cpp index 534ea226..71c8e314 100644 --- a/scanners/code_scanner.cpp +++ b/scanners/code_scanner.cpp @@ -10,7 +10,7 @@ using namespace pesieve; using namespace pesieve::util; -size_t pesieve::CodeScanReport::generateTags(std::string reportPath) +size_t pesieve::CodeScanReport::generateTags(const std::string& reportPath) { if (patchesList.size() == 0) { return 0; diff --git a/scanners/code_scanner.h b/scanners/code_scanner.h index 24fc6e86..3993f73d 100644 --- a/scanners/code_scanner.h +++ b/scanners/code_scanner.h @@ -96,7 +96,7 @@ namespace pesieve { return countSectionsWithStatus(SECTION_SCAN_ERR); } - size_t generateTags(std::string reportPath); + size_t generateTags(const std::string &reportPath); std::map sectionToResult; PatchList patchesList; diff --git a/scanners/iat_scanner.cpp b/scanners/iat_scanner.cpp index 4af1fe62..0f0f536b 100644 --- a/scanners/iat_scanner.cpp +++ b/scanners/iat_scanner.cpp @@ -89,7 +89,7 @@ std::string IATScanReport::formatHookedFuncName(IN peconv::ImportsCollection* st } -bool IATScanReport::saveNotRecovered(IN std::string fileName, +bool IATScanReport::saveNotRecovered(IN const std::string& fileName, IN HANDLE hProcess, IN peconv::ImportsCollection *storedFunc, IN peconv::ImpsNotCovered ¬Covered, diff --git a/scanners/iat_scanner.h b/scanners/iat_scanner.h index d6234bf8..4e0d9b24 100644 --- a/scanners/iat_scanner.h +++ b/scanners/iat_scanner.h @@ -12,7 +12,7 @@ namespace pesieve { { public: - static bool saveNotRecovered(IN std::string fileName, + static bool saveNotRecovered(IN const std::string &fileName, IN HANDLE hProcess, IN peconv::ImportsCollection *storedFunc, IN peconv::ImpsNotCovered ¬Covered, diff --git a/scanners/thread_scanner.cpp b/scanners/thread_scanner.cpp index 5a5ffb86..10810693 100644 --- a/scanners/thread_scanner.cpp +++ b/scanners/thread_scanner.cpp @@ -219,7 +219,7 @@ bool pesieve::ThreadScanner::checkReturnAddrIntegrity(IN const std::vector call_stack, IN OUT ctx_details& cDetails) +size_t pesieve::ThreadScanner::analyzeCallStack(IN const std::vector &call_stack, IN OUT ctx_details& cDetails) { size_t processedCntr = 0; diff --git a/scanners/thread_scanner.h b/scanners/thread_scanner.h index dda45dd4..7ceb26e2 100644 --- a/scanners/thread_scanner.h +++ b/scanners/thread_scanner.h @@ -144,7 +144,7 @@ namespace pesieve { bool printResolvedAddr(ULONGLONG addr); bool fetchThreadCtxDetails(IN HANDLE hProcess, IN HANDLE hThread, OUT ctx_details& c); size_t fillCallStackInfo(IN HANDLE hProcess, IN HANDLE hThread, IN LPVOID ctx, IN OUT ctx_details& cDetails); - size_t analyzeCallStack(IN const std::vector stack_frame, IN OUT ctx_details& cDetails); + size_t analyzeCallStack(IN const std::vector &stack_frame, IN OUT ctx_details& cDetails); bool checkReturnAddrIntegrity(IN const std::vector& callStack); bool fillAreaStats(ThreadScanReport* my_report); bool reportSuspiciousAddr(ThreadScanReport* my_report, ULONGLONG susp_addr); diff --git a/stats/stats_analyzer.cpp b/stats/stats_analyzer.cpp index 4e8bd55d..5d346ae9 100644 --- a/stats/stats_analyzer.cpp +++ b/stats/stats_analyzer.cpp @@ -56,7 +56,7 @@ namespace pesieve { return points; } - size_t countFoundStrings(IN const AreaMultiStats& stats, IN std::set neededStrings, IN size_t minOccurrence) + size_t countFoundStrings(IN const AreaMultiStats& stats, IN const std::set &neededStrings, IN size_t minOccurrence) { size_t totalCount = 0; if (!stats.currArea.foundStrings.size()) { @@ -100,7 +100,7 @@ namespace pesieve { { size_t valsCount = 0; for (auto itr1 = currArea.frequencies.rbegin(); itr1 != currArea.frequencies.rend(); ++itr1) { - double counter = itr1->first; + double counter = (double)itr1->first; if (counter >= mean) { valsCount += itr1->second.size(); } diff --git a/utils/path_converter.cpp b/utils/path_converter.cpp index 841af4ee..e218c858 100644 --- a/utils/path_converter.cpp +++ b/utils/path_converter.cpp @@ -125,7 +125,7 @@ namespace pesieve { return false; } - std::string remap_to_drive_letter(std::string full_path) + std::string remap_to_drive_letter(const std::string &full_path) { size_t full_path_size = full_path.length(); if (full_path_size == 0) { @@ -237,7 +237,7 @@ std::string pesieve::util::device_path_to_win32_path(const std::string &full_pat return path; } -bool is_device_path(std::string path) +bool is_device_path(const std::string &path) { const std::string device_path = "\\Device\\"; if (path.length() < device_path.length() || path[0] !='\\') { @@ -249,7 +249,7 @@ bool is_device_path(std::string path) return false; } -std::string pesieve::util::expand_path(std::string path) +std::string pesieve::util::expand_path(const std::string &path) { std::string basic_path = pesieve::util::device_path_to_win32_path(path); if (is_device_path(basic_path)) { @@ -270,4 +270,3 @@ std::string pesieve::util::expand_path(std::string path) } return strip_prefix(filename, LONG_PATH_PREFIX); } - diff --git a/utils/path_converter.h b/utils/path_converter.h index c81548f8..71af1ba7 100644 --- a/utils/path_converter.h +++ b/utils/path_converter.h @@ -15,7 +15,7 @@ namespace pesieve { //converts path in format i.e.: \Device\HarddiskVolume2\... to format: C:\... std::string device_path_to_win32_path(const std::string &full_path); - std::string expand_path(std::string path); + std::string expand_path(const std::string &path); }; };