Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with backbone 1.1.2 #3

Closed
creynders opened this issue Sep 24, 2014 · 2 comments
Closed

Does not work with backbone 1.1.2 #3

creynders opened this issue Sep 24, 2014 · 2 comments

Comments

@creynders
Copy link

I tried using backbone.select, but noticed it didn't function properly in my project, so I set up a bare bones example using your "introductory example", but it still doesn't work unfortunately.

I get the following in the console:

"error"
"TypeError: Cannot read property 'id' of undefined
    at http://run.jsbin.com/runner:24:58"

which points to the statement console.log( collection.selected.id );
And this console.log( m1.selected ); outputs undefined as well.

@hashchange
Copy link
Owner

I just had a look and indeed, Backbone.Select breaks if you use it in conjunction with Underscore 1.7.0. That is an Underscore issue, though, because 1.7.0 has broken tons of stuff and has been a disaster from start to finish. Have a look at jashkenas/underscore#1805 and cry.

The situation hasn't really improved since. Jeremy Ashkenas has announced that 1.7.0 is going to be reverted. But that was four weeks ago, and it still hasn't happened. He hasn't publicly retracted that announcement, either.

So the situation is pretty confused. I won't adapt Backbone.Select to new Underscore versions until this mess is sorted out. Please stick to Underscore 1.6.0 for now if you'd like to use Backbone.Select. (Probably a good idea anyway.)

If you use Bower, npm or Browserify to manage your dependencies, they will do the right thing. Unfortunately, there isn't really anything else I can do at the moment.

@creynders
Copy link
Author

Thanks for the extensive answer! Didn't know _ v1.7 was so bad, I'll definitely switch back to v1.6!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants