endpoint not working - gtfs_ride_stops/list?gtfs_ride_ids=<id>

[NoamGaash]

the endpoint -
https://open-bus-stride-api.hasadna.org.il/gtfs_ride_stops/list?gtfs_ride_ids=42934600
keeps the client side hanging without a response.
removing the gtfs_ride_ids field works just fine

[OriHoch]

@NoamGaash This results in a heavy query on the DB, I suggest to always add gtfs date ranges to your your queries, then it will return very fast:

https://open-bus-stride-api.hasadna.org.il/gtfs_ride_stops/list?gtfs_ride_ids=42934600&gtfs_stop__date_from=2023-05-20&gtfs_stop__date_to=2023-05-30&gtfs_route__date_from=2023-05-20&gtfs_route__date_to=2023-05-30

[ShayAdler]

@NoamGaash just as thinking of ideas for small donations, do you think it would be helpful to add a limit in the API for that (fail immediately when not enough filters are supplied?)

[NoamGaash]

That's a great idea. It should be implemented to return error 400

[ohaval]

Hey, I want to take and work on this little issue.

[NoamGaash]

@ohaval great, thanks!

[OriHoch]

@ohaval you can contact me on hasadna slack if you want guidance / help with this task

[OriHoch]

fixed in #42

[NoamGaash]

Thanks, but seems like we're now having a frontend problem:

Did #42 changed this api?
https://open-bus-stride-api.hasadna.org.il/gtfs_ride_stops/list?gtfs_ride_ids=66912328
It used to work

https://open-bus-map-search.hasadna.org.il/timeline?timestamp=1707742801451&operatorId=3&lineNumber=1&routeKey=%D7%94%D7%A0%D7%93%D7%99%D7%91%2F%D7%94%D7%9E%D7%99%D7%99%D7%A1%D7%93%D7%99%D7%9D-%D7%96%D7%9B%D7%A8%D7%95%D7%9F+%D7%99%D7%A2%D7%A7%D7%91%3C-%3E%D7%94%D7%A0%D7%93%D7%99%D7%91%2F%D7%94%D7%9E%D7%99%D7%99%D7%A1%D7%93%D7%99%D7%9D-%D7%96%D7%9B%D7%A8%D7%95%D7%9F+%D7%99%D7%A2%D7%A7%D7%91-3%D7%97

[OriHoch]

@NoamGaash @ohaval fixed to allow requests for a specific gtfs ride id