feat: add to single line map arrowa to navigate between points #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorinzrihen
changed the title
NoamGaash
approved these changes
Jun 13, 2024
| className={`${checkIfValidStep(rightStep) ? '' : 'disabled'}`} | ||
| onClick={() => navigateMarkers(rightStep)} | ||
| /> | ||
| <LeftOutlined |
There was a problem hiding this comment.
we can add a "title" attribute for hover ("prev" / "next")
There was a problem hiding this comment.
I choose to use right/left-chevron instead cuz 'prev' 'next' depend on the direction
There was a problem hiding this comment.
the title attribute is visible to users, and should help them understand whether right will indicate the previous or the next item of the list.
In RTL website, it's common to see right arrows serving as "next" buttons, while on LTR website it's the opposite, that's why I feel having this title can be significant to the user experience
| return ( | ||
| <div className="map-footer-buttons"> | ||
| <RightOutlined | ||
| className={`${checkIfValidStep(rightStep) ? '' : 'disabled'}`} |
There was a problem hiding this comment.
just an idea - we can hide the button if it's not relevant for this data point
NoamGaash
changed the title
dorinzrihen
deleted the
feat/add-to-single-line-map-arrowa-to-navigate-between-points
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#776
it's not solution with more zoom (i check with the docs and it look like it's the maximum)
screenshots