feat: Added complaint button, hidden as an easter egg 'complaint'. #791

LiadOvdat5 · 2024-06-09T16:26:44Z

New Feature

Description

When opened you can write your info and submit.
to show the button, write 'complaint'

screenshots

when opened you can write your info and submit.

…open-bus-map-search into Add-Complaint-Button

NoamGaash

good job! do you need any help with the linting warnings?

src/pages/components/map-related/MapLayers/ComplaintModal.tsx

Co-authored-by: Noam Gaash <[email protected]>

LiadOvdat5 · 2024-06-11T09:26:47Z

good job! do you need any help with the linting warnings?

Yes I would love that,
I have warning on the any in siriRide in the interface

what should I put there instead?
Or I should just import them as in the BusToolTip (using useEffect at the start)?

supervxn · 2024-06-13T13:19:10Z

@LiadOvdat5 - the frontend side looks clear and simple. 😺.

NoamGaash

Sorry for the delay, seems like you solved all linting issues + the code seems great!
We would love to have this merged. Thank you! 👏 🥇

NoamGaash

some comments - can be fixed after merge, or be opened as a new issue

NoamGaash · 2024-06-14T17:56:54Z

src/pages/components/map-related/MapLayers/ComplaintModal.tsx

+              <TextField
+                label={t('email')}
+                name="email"
+                value={complaintData.email}
+                onChange={handleInputChange}
+                fullWidth
+                margin="normal"
+              />


if you'll add type=email, then it will show better keyboard on some devices and also be more accessible.
same can be done for numbers and phone numbers
(can be done in future PR)

NoamGaash · 2024-06-14T17:58:22Z

src/locale/he.json

@@ -134,6 +134,29 @@
  "coords": "נ.צ.",
  "hide_document": "הסתר מידע לגיקים",
  "show_document": "הצג מידע לגיקים",
+  "open_complaint": "פתח תלונה",
+  "close_complaint": "סגור תלונה",


Suggested change

"close_complaint": "סגור תלונה",

"close_complaint": "בטל תלונה",

NoamGaash · 2024-06-14T17:59:33Z

src/pages/components/map-related/MapLayers/ComplaintModal.tsx

+            </form>
+            <Button
+              variant="contained"
+              color="success"


this button will lead the user to cancel their complaint and potentially loose everything they typed

Suggested change

color="success"

color="danger"

NoamGaash · 2024-06-14T18:04:09Z

src/pages/components/map-related/MapLayers/ComplaintModal.tsx

+    border: '2px solid #000',
+    boxShadow: 24,
+    p: 4,
+    textAlign: i18n.language === 'he' ? 'left' : 'right',


something feels weird about this condition, are you sure it works as intended?

supervxn · 2024-06-14T18:08:07Z

Loving the speed here 🙌.
Let me know when it's live.

NoamGaash · 2024-06-14T18:50:56Z

@supervxn Once the pull request is merged (you'll probably get a notification about it) the deployment process will start automatically. It takes 10 minutes on average, but sometime (rarely) it gets stuck for about a day

github-actions · 2024-06-18T05:58:05Z

Preview: https://s3.amazonaws.com/noam-gaash.co.il/9559894563/open-bus/6/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/9559894563/open-bus/6/storybook/index.html

NoamGaash · 2024-06-18T06:12:46Z

@supervxn
From now on previews are also available on forks, so you can see the feature live.

NoamGaash · 2024-06-18T10:16:21Z

@all-contributors please add @LiadOvdat5 for code

allcontributors · 2024-06-18T10:16:31Z

@NoamGaash

I've put up a pull request to add @LiadOvdat5! 🎉

supervxn · 2024-06-18T12:42:37Z

@supervxn From now on previews are also available on forks, so you can see the feature live.

is this the right fork?

If so, how can I preview (without installing anything)?
https://github.com/LiadOvdat5/open-bus-map-search

NoamGaash · 2024-06-18T13:16:39Z

@supervxn have you seen this comment?

#791 (comment)

supervxn · 2024-06-18T13:29:19Z

Preview: https://s3.amazonaws.com/noam-gaash.co.il/9559894563/open-bus/6/index.html Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/9559894563/open-bus/6/storybook/index.html

I type complaint and nothing happens

NoamGaash · 2024-06-18T14:10:48Z

did you click on a bus icon inside the real-time map page before typing complaint?
did you use english keyboard?

NoamGaash · 2024-06-18T14:12:02Z

Also, now when this PR is merged, you can see it on production
https://open-bus-map-search.hasadna.org.il/map

supervxn · 2024-06-18T15:25:27Z

Got it! Thanks @LiadOvdat5 - you rock!

BTW: is the form connected to somewhere already?

NoamGaash · 2024-06-19T06:05:43Z

not yet

supervxn · 2024-06-19T13:40:58Z

not yet

Phew.

Added complaint button, hidden as an easter egg 'complaint'.

ef84f83

when opened you can write your info and submit.

LiadOvdat5 requested a review from NoamGaash as a code owner June 9, 2024 16:26

LiadOvdat5 changed the title ~~Added complaint button, hidden as an easter egg 'complaint'.~~ A bug fix: Added complaint button, hidden as an easter egg 'complaint'. Jun 9, 2024

LiadOvdat5 changed the title ~~A bug fix: Added complaint button, hidden as an easter egg 'complaint'.~~ fix: Added complaint button, hidden as an easter egg 'complaint'. Jun 9, 2024

LiadOvdat5 changed the title ~~fix: Added complaint button, hidden as an easter egg 'complaint'.~~ feat: Added complaint button, hidden as an easter egg 'complaint'. Jun 9, 2024

LiadOvdat5 and others added 6 commits June 10, 2024 08:57

fix bug

41607a6

Merge branch 'main' into Add-Complaint-Button

61dc27e

fix bug

c54eaf4

Merge branch 'Add-Complaint-Button' of https://github.com/LiadOvdat5/…

2958356

…open-bus-map-search into Add-Complaint-Button

fix bug

316a8f4

returning position and siriRide to any in ComplaintModal

0e98a9d

NoamGaash reviewed Jun 10, 2024

View reviewed changes

src/pages/components/map-related/MapLayers/ComplaintModal.tsx Outdated Show resolved Hide resolved

src/pages/components/map-related/MapLayers/ComplaintModal.tsx Outdated Show resolved Hide resolved

LiadOvdat5 and others added 2 commits June 11, 2024 12:22

Update src/pages/components/map-related/MapLayers/ComplaintModal.tsx

f8dab1c

Co-authored-by: Noam Gaash <[email protected]>

Update src/pages/components/map-related/MapLayers/ComplaintModal.tsx

94715df

Co-authored-by: Noam Gaash <[email protected]>

LiadOvdat5 added 2 commits June 11, 2024 12:32

making position point

13023c7

bring siriRide from inside of complaint modal instead of treafering it

b5e1761

NoamGaash self-requested a review June 13, 2024 13:13

NoamGaash approved these changes Jun 14, 2024

View reviewed changes

NoamGaash reviewed Jun 14, 2024

View reviewed changes

NoamGaash mentioned this pull request Jun 18, 2024

Apply code review comments #817

Closed

Merge branch 'main' into Add-Complaint-Button

457fe41

refactor: lint fix

f8b6fb4

NoamGaash merged commit dbbf9a0 into hasadna:main Jun 18, 2024
13 checks passed

allcontributors bot mentioned this pull request Jun 18, 2024

docs: add LiadOvdat5 as a contributor for code #820

Merged

github-actions bot mentioned this pull request Jun 18, 2024

chore(main): release 1.0.0 #432

Merged

github-actions bot mentioned this pull request Jul 2, 2024

chore(main): release 1.1.0 #845

Merged

NoamGaash mentioned this pull request Aug 14, 2024

Feature | Add complaint button to bus tooltip #774

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Added complaint button, hidden as an easter egg 'complaint'. #791

feat: Added complaint button, hidden as an easter egg 'complaint'. #791

LiadOvdat5 commented Jun 9, 2024 •

edited

Loading

NoamGaash left a comment

LiadOvdat5 commented Jun 11, 2024 •

edited

Loading

supervxn commented Jun 13, 2024

NoamGaash left a comment

NoamGaash left a comment

NoamGaash Jun 14, 2024

NoamGaash Jun 14, 2024

NoamGaash Jun 14, 2024

NoamGaash Jun 14, 2024

supervxn commented Jun 14, 2024

NoamGaash commented Jun 14, 2024 •

edited

Loading

github-actions bot commented Jun 18, 2024 •

edited

Loading

NoamGaash commented Jun 18, 2024

NoamGaash commented Jun 18, 2024

allcontributors bot commented Jun 18, 2024

supervxn commented Jun 18, 2024 •

edited

Loading

NoamGaash commented Jun 18, 2024

supervxn commented Jun 18, 2024

NoamGaash commented Jun 18, 2024

NoamGaash commented Jun 18, 2024

supervxn commented Jun 18, 2024 •

edited

Loading

NoamGaash commented Jun 19, 2024

supervxn commented Jun 19, 2024

	"close_complaint": "סגור תלונה",
	"close_complaint": "בטל תלונה",

feat: Added complaint button, hidden as an easter egg 'complaint'. #791

feat: Added complaint button, hidden as an easter egg 'complaint'. #791

Conversation

LiadOvdat5 commented Jun 9, 2024 • edited Loading

Description

screenshots

NoamGaash left a comment

Choose a reason for hiding this comment

LiadOvdat5 commented Jun 11, 2024 • edited Loading

supervxn commented Jun 13, 2024

NoamGaash left a comment

Choose a reason for hiding this comment

NoamGaash left a comment

Choose a reason for hiding this comment

NoamGaash Jun 14, 2024

Choose a reason for hiding this comment

NoamGaash Jun 14, 2024

Choose a reason for hiding this comment

NoamGaash Jun 14, 2024

Choose a reason for hiding this comment

NoamGaash Jun 14, 2024

Choose a reason for hiding this comment

supervxn commented Jun 14, 2024

NoamGaash commented Jun 14, 2024 • edited Loading

github-actions bot commented Jun 18, 2024 • edited Loading

NoamGaash commented Jun 18, 2024

NoamGaash commented Jun 18, 2024

allcontributors bot commented Jun 18, 2024

supervxn commented Jun 18, 2024 • edited Loading

NoamGaash commented Jun 18, 2024

supervxn commented Jun 18, 2024

NoamGaash commented Jun 18, 2024

NoamGaash commented Jun 18, 2024

supervxn commented Jun 18, 2024 • edited Loading

NoamGaash commented Jun 19, 2024

supervxn commented Jun 19, 2024

LiadOvdat5 commented Jun 9, 2024 •

edited

Loading

LiadOvdat5 commented Jun 11, 2024 •

edited

Loading

NoamGaash commented Jun 14, 2024 •

edited

Loading

github-actions bot commented Jun 18, 2024 •

edited

Loading

supervxn commented Jun 18, 2024 •

edited

Loading

supervxn commented Jun 18, 2024 •

edited

Loading