Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dark mode hides map legend #760

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

itsoriki
Copy link
Collaborator

Resolves #579

Description

The map legend was kind of transparent in dark mode - I fixed it

Note: I have noticed there is a complete mess using different component libraries and configuring each one's dark mode options - the code is cumbersome - maybe we should consider sticking (strictly) with one library (and and replacing the others (e.g. MUI and not AntDesign - I have no personal preference)

screenshots

Before:
image

After:
image

@itsoriki itsoriki marked this pull request as ready for review May 21, 2024 14:46
@itsoriki itsoriki requested a review from NoamGaash as a code owner May 21, 2024 14:46
@itsoriki itsoriki requested a review from dorinzrihen May 21, 2024 14:47
@NoamGaash
Copy link
Member

regarding your note - see #752

@itsoriki itsoriki merged commit f413ae5 into main May 22, 2024
17 checks passed
@itsoriki itsoriki deleted the fix/579-dark-mode-hides-map-legend branch May 22, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode hides map legends
2 participants