Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add donations modal #552

Merged
merged 9 commits into from
May 15, 2024
Merged

feat: add donations modal #552

merged 9 commits into from
May 15, 2024

Conversation

NoamGaash
Copy link
Member

Description

Create a modal for donations

screenshots

image
image

@NoamGaash NoamGaash requested a review from R894 March 4, 2024 21:48
src/layout/header/DonationButton.tsx Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@aviv1620 aviv1620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@aviv1620
Copy link
Collaborator

aviv1620 commented Mar 5, 2024

I miss that you remove the donation button from side bar.
I think it better to keep it and stay two donation buttons

luck we have visual tests.

Screenshot 2024-03-05 180854

@NoamGaash
Copy link
Member Author

@aviv1620 isn't it a little pushy?

@aviv1620
Copy link
Collaborator

aviv1620 commented Mar 6, 2024

pushy

I don't think so.

@NoamGaash
Copy link
Member Author

thank, I'll fix it on weekend / Monday

@NoamGaash NoamGaash merged commit 8cda1a6 into main May 15, 2024
16 checks passed
@NoamGaash NoamGaash deleted the feat/add-donations-modal branch May 15, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants