Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link bus tooltips to line profile page #457

Closed
NoamGaash opened this issue Feb 6, 2024 · 3 comments · Fixed by #463
Closed

Link bus tooltips to line profile page #457

NoamGaash opened this issue Feb 6, 2024 · 3 comments · Fixed by #463
Assignees
Labels
enhancement New feature or request frontend frontend developers issue good first issue Good for newcomers line profile page

Comments

@NoamGaash
Copy link
Member

NoamGaash commented Feb 6, 2024

In every map, when clicking a bus icon, there is a tooltip with information regarding the bus.

Add a button that will link to /profile/routeId

image

@NoamGaash NoamGaash added enhancement New feature or request good first issue Good for newcomers frontend frontend developers issue line profile page labels Feb 6, 2024
@YuvalMasada
Copy link
Collaborator

@NoamGaash
Ill take it.

@YuvalMasada
Copy link
Collaborator

YuvalMasada commented Feb 8, 2024

ok,
I've made a Small change in The BusToolTip component. Wrapped the bus's line name with Link.
It doesn't change the old behavior.
const LinkToProfile = siriRide ? ( <Link to={/profile/${siriRide.gtfsRouteRouteShortName}}> {siriRide && siriRide.gtfsRouteRouteShortName}{" "} </Link> ) : null;
Adding a screenshot of the new look:
ToolTip look

if it's ok i'll commit it.

@NoamGaash
Copy link
Member Author

it sounds great, but please open a pull request so we can see and discuss it

@NoamGaash NoamGaash linked a pull request Feb 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend frontend developers issue good first issue Good for newcomers line profile page
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants