Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add page descriptions #452

Merged
merged 18 commits into from
Mar 14, 2024
Merged

feat: add page descriptions #452

merged 18 commits into from
Mar 14, 2024

Conversation

itai-rozen
Copy link
Contributor

@itai-rozen itai-rozen commented Feb 4, 2024 •
edited
Loading

Description

  1. titles in navbar are now the same as page titles
  2. added descriptions below page titles in hebrew & english

screenshots

image
image
image
image

@NoamGaash NoamGaash changed the title Improve descriptions feat: add page descriptions Feb 5, 2024
@NoamGaash
Copy link
Member

thanks!
please address the building & linting issue (you may run npm run lint locally or visit this link)

all ❌ should be solved
image

@itai-rozen
Copy link
Contributor Author

not sure what went wrong here.. any help?

@shootermv
Copy link
Collaborator

Will be glad to try help you. Do you have a discord ?

@itai-rozen
Copy link
Contributor Author

itai-rozen commented Feb 12, 2024 via email

@NoamGaash
Copy link
Member

it said that the operation was canceled. I'll try to re-run

NoamGaash
NoamGaash reviewed Feb 12, 2024
View reviewed changes
tests/menu.spec.ts Outdated Show resolved Hide resolved
@NoamGaash
Copy link
Member

would you please solve the conflicts and add some screenshots?
thanks

NoamGaash
NoamGaash approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aviv1620
Copy link
Collaborator

Screenshot 2024-03-11 165741

@aviv1620 aviv1620 requested a review from NoamGaash March 12, 2024 08:23
@shootermv shootermv merged commit 43a25b5 into hasadna:main Mar 14, 2024
17 checks passed
@github-actions github-actions bot mentioned this pull request Mar 14, 2024
Merged
@github-actions github-actions bot mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviv1620 aviv1620 aviv1620 approved these changes

@NoamGaash NoamGaash Awaiting requested review from NoamGaash NoamGaash is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itai-rozen @NoamGaash @shootermv @aviv1620