feat: Add an Operator Selector to data-research page #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 26, 2024 09:30
NoamGaash
requested changes
Jan 28, 2024
src/model/operator.ts
Outdated
Comment on lines
11
to
17
| const allOperators = Array.from( | ||
| agencyList.map((agency) => ({ | ||
| name: agency.agency_name, | ||
| id: agency.operator_ref.toString(), | ||
| })), | ||
| ) | ||
| allOperators.push({ name: 'הכל', id: '' }) |
There was a problem hiding this comment.
why do we need the הכל here?
Suggested change
| const allOperators = Array.from( | |
| agencyList.map((agency) => ({ | |
| name: agency.agency_name, | |
| id: agency.operator_ref.toString(), | |
| })), | |
| ) | |
| allOperators.push({ name: 'הכל', id: '' }) | |
| const allOperators = agencyList.map((agency) => ({ | |
| name: agency.agency_name, | |
| id: agency.operator_ref.toString(), | |
| })) | |
| allOperators.push({ name: 'הכל', id: '' }) |
There was a problem hiding this comment.
Changed, Thanks! (assumed the problem with adding this in this function doesn't fit the function name?)
There was a problem hiding this comment.
Thanks! It's also about the data model should not be aware of the UI options
…s-map-search into add-operator-selector
NoamGaash
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the selection option of operators on the research page
