Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scrollbar color on dark mode #431

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

YahavSofer
Copy link
Contributor

Description

I updated the ThemeContext.tsx so the scrollbar on dark mode will be part of the color scheme.
I found the solution in MUI documentation in this link

screenshots

image

Copy link
Collaborator

@shootermv shootermv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks grate!

@R894 R894 linked an issue Jan 24, 2024 that may be closed by this pull request
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both changes looks great. thank you!
I'd do in in separate PRs but that's great

@shootermv shootermv merged commit dfcedf1 into hasadna:main Jan 25, 2024
17 checks passed
VSciFlight added a commit to VSciFlight/open-bus-map-search that referenced this pull request Jan 30, 2024


* 'main' of https://github.com/VSciFlight/open-bus-map-search: (94 commits)
  chore: lint css (hasadna#442)
  style: Ensure minimum width for ArrivalByTimeChart  (hasadna#433)
  fix: Remove unknown data (hasadna#438)
  chore: Revert "chore: add temporary route for the version release event (hasadna#382)" (hasadna#441)
  ci: upgrade linter (hasadna#439)
  fix: scrollbar color on dark mode (hasadna#431)
  fix: Fix for issue hasadna#428 unable to run project locally (hasadna#430)
  chore: Adding tnufa to dropdown in dashboard hasadna#423 (hasadna#429)
  chore(main): release 1.0.0 (hasadna#326)
  fix: make input labels visible at dark mode (hasadna#424)
  fix: make top input label visible at singleLine page (hasadna#420)
  chore: add i18n type safety (hasadna#419)
  feat: add home-page files and temp route (hasadna#403)
  feat: finish bug report form creation (hasadna#411)
  feat: Translation of the remaining untranslated text on the About page (hasadna#399)
  test: add SinglelinePage tests (hasadna#393)
  feat: made logo white on dark mode (hasadna#397)
  feat: date picker component show invalid dates warning (hasadna#398)
  chore: hide bug report form (hasadna#388)
  docs: fixed a dead link in README.md (hasadna#396)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect scrollbar styling when swapping to dark mode
3 participants