Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve sidebar & logo design #137

Merged
merged 2 commits into from
Oct 29, 2023
Merged

feat: improve sidebar & logo design #137

merged 2 commits into from
Oct 29, 2023

Conversation

shootermv
Copy link
Collaborator

@shootermv shootermv commented Oct 20, 2023

closes #132

Description

new design for a sidebar

screenshots

desktop:
image

mobile (menu closed):
image

mobile (menu open):
image

@shootermv shootermv force-pushed the new-design branch 2 times, most recently from 1c769c7 to 9e80a7a Compare October 20, 2023 10:37
@giladfuchs
Copy link
Collaborator

hi @shootermv you need to fix the conflict.

and you have ts error for pages.

@shootermv shootermv force-pushed the new-design branch 7 times, most recently from 65e6f02 to bce3d0d Compare October 26, 2023 07:45
@NoamGaash
Copy link
Member

@shootermv please fix the conflicts

@netlify
Copy link

netlify bot commented Oct 28, 2023

Deploy Preview for astonishing-pothos-5f81bd ready!

Name Link
🔨 Latest commit d02fd4e
🔍 Latest deploy log https://app.netlify.com/sites/astonishing-pothos-5f81bd/deploys/653d6ab42be2440008f407b1
😎 Deploy Preview https://deploy-preview-137--astonishing-pothos-5f81bd.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing.
Let's merge it.
However, please take into account that the logo could be changed in the future 🙏

@shootermv shootermv merged commit 22df36e into main Oct 29, 2023
10 checks passed
@NoamGaash NoamGaash deleted the new-design branch October 29, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new design suggestion for sidebar
3 participants