controller/node: skip update vlanconfig with witness node (backport #105) #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
We need PR #107 to be merged first, then CI will pass. |
mingshuoqiu
approved these changes
Aug 9, 2024
|
@Mergifyio rebase |
❌ Unable to rebase: user
|
- we did not apply any vlanconfig on the witness node,
so we need to skip the vlanconfig update when witness
node change.
Signed-off-by: Vicente Cheng <[email protected]>
(cherry picked from commit 9ca1501)
Vicente-Cheng
force-pushed
the
mergify/bp/v0.4.x/pr-105
branch
from
2d172b0
to
2d8063b
Compare
starbops
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Now, the
matched-nodeswill filter out the witness node with creation.However, the controller has a chance to update the witness node to the
matched-nodeson the controller part.Solution:
We need to skip to update the
matched-nodeswith the witness node change.Related Issue:
#104 (comment)
Test plan:
Make sure the
matched-nodesannotation of vlanconfig does not contain any witness node.This is an automatic backport of pull request #105 done by [Mergify](https://mergify.com).