Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is checkout step really necessary? #21

Open
Ameausoone opened this issue Dec 8, 2020 · 2 comments
Open

Is checkout step really necessary? #21

Ameausoone opened this issue Dec 8, 2020 · 2 comments

Comments

@Ameausoone
Copy link

In your example:

    steps:
      - uses: actions/checkout@master
      - uses: harupy/comment-on-pr@master
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        with:
          filename: template.md

Does the step actions/checkout@master is really necessary for add a comment on a PR ?

Pipeline would be slightly faster without checkout step.

@Thomas-Boi
Copy link

I think this is due to the template.md. If you don't check out, you don't have the template

@gqqnbig
Copy link

gqqnbig commented Apr 1, 2021

It's possible to create arbitary file on the fly and use this file as the template. A caveat is that the action by default looks up files in .github/workflow or you use filename: ../../template.md to go back to the current directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants