Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding own language breaks with version 0.3.0 #24

Closed
tobschu94 opened this issue Jul 5, 2024 · 8 comments · Fixed by #25
Closed

Adding own language breaks with version 0.3.0 #24

tobschu94 opened this issue Jul 5, 2024 · 8 comments · Fixed by #25

Comments

@tobschu94
Copy link

When upgrading the package to version 0.3.0 adding my own language called docgen breaks:

I did not change anything on my langauge and added is via the VS code settings.json:

image

However, using built-in languages does still work.
Therefore, do I need to modify anything within my custom language?

@tobschu94
Copy link
Author

Through some research I could find out, that removing the doubl quotes from your extension.json file might be the issue, as the VS Code settings.json only accepts double quotes keys and my language can't be found anymore by your package

@harrydowning
Copy link
Owner

Removing the double quotes shouldn't break anything as extension.js is only a generator file that converts the Javascript objects to JSON. Could you update/restart VS Code to see if that fixes the issue? I've just tried this myself on version v0.3.1 and haven't had a problem.

@harrydowning
Copy link
Owner

Actually, this is most likely because when a new version of the extension is installed, it overwrites the previous. This will overwrite any languages added through the extension setting. For now, by modifying the yaml-embedded-languages.include your language should be added again. I'll look to change this so it doesn't happen.

@harrydowning
Copy link
Owner

This should be fixed in v0.3.2

@tobschu94
Copy link
Author

tobschu94 commented Jul 10, 2024

Hello,
I tried all your points, but nothing worked.
Actually the settings.json did not change at all when installing a new version of your package and my custom language was still included.

However, no success.

The only thing that worked was modifying your extension.json and adding my language manually there (without double quotes), then I could use it.
So I think somehow your changes led to not finding my language when putting it into the settings.json because simply downgrading to v0.2.0 works fine without modifying anything else

@tobschu94
Copy link
Author

And for all my team mates the same error appears

@harrydowning harrydowning reopened this Jul 18, 2024
@harrydowning
Copy link
Owner

Sorry I missed this. So updating to v0.3.3 didn't work? Would it be possible for you to create a small sample language to reproduce the issue?

@tobschu94
Copy link
Author

Hi, so I checked again and somehow when updating your package a reinstallation of my custom language package is necessary, but I could not figure out why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants